Skip to content

Document the ACL DIGEST command - #469

Open
melancholictheory wants to merge 1 commit into
valkey-io:mainfrom
melancholictheory:acl-digest
Open

Document the ACL DIGEST command#469
melancholictheory wants to merge 1 commit into
valkey-io:mainfrom
melancholictheory:acl-digest

Conversation

@melancholictheory

Copy link
Copy Markdown

Documentation for ACL DIGEST, the command added in valkey-io/valkey#4446 and requested in valkey-io/valkey#4355.

ACL DIGEST returns a fingerprint of the ACL rules currently in effect, as a hexadecimal string. A controller that manages users through an ACL file can read it before and after an ACL LOAD and tell whether the file it wrote is the one now in effect. Comparing the rules instead does not work, because the server reports them in its own normalized form rather than the form they were written in.

This adds commands/acl-digest.md and the matching entries in resp2_replies.json and resp3_replies.json.

It should land after or together with the server PR. Until the command JSON exists in valkey, the Makefile leaves the page out of the build, since commands is the intersection of the Markdown pages and the JSON files under VALKEY_ROOT/src/commands, so nothing breaks in the meantime.

Checks

The example output on the page was taken from a server built from the command branch rather than written by hand.

With VALKEY_ROOT pointed at that branch, make builds _build/man/man3/acl-digest.3valkey.gz. The summary, complexity, ACL categories, since version and reply description all resolve, and the links to ACL LIST and ACL LOAD render as man page references.

utils/check-links.pl reports no broken links, and spellchecker-cli is clean against .spellcheckerrc.yml.

ACL DIGEST returns a fingerprint of the ACL rules currently in effect,
as a hexadecimal string, so a client can tell which revision of an ACL a
server is running without comparing the rules themselves.

Adds the command page and the RESP2 and RESP3 reply descriptions.

Signed-off-by: melancholictheory <selimvhorst@gmail.com>

@zuiderkwast zuiderkwast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Waiting for valkey-io/valkey#4446 to be merged (and for the major decision to be approved) before merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants