Skip to content

Update resp2_replies.json about JSON.CLEAR #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
momadvisor wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Update resp2_replies.json about JSON.CLEAR #286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efa51b9
Update resp2_replies.json
momadvisor May 29, 2025
cddf4e0
Update resp2_replies.json
momadvisor May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion resp2_replies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,8 +746,9 @@
"* [Integer reply](../topics/protocol.md#integers):",
" * The number of containers cleared.",
" * Returns 0 if clearing an empty array or object.",
Comment on lines 747 to 748

@roshkhatri roshkhatri Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" * The number of containers cleared.",
" * Returns 0 if clearing an empty array or object.",
" * The number of values cleared.",
" * A value is counted only when clearing changes it: a non-empty array or object is emptied, a non-empty string is set to empty, a non-zero number is set to 0, and true is set to false.",
" * Returns 0 for a value already empty, zero, false, or null.",

" * Returns 0 if clearing a non-container value.",
" * Returns 0 if clearing a non-container value except JSON string.",

@sarthakaggarwal97 sarthakaggarwal97 Aug 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need this.

@roshkhatri roshkhatri Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" * Returns 0 if clearing a non-container value except JSON string.",
" * Returns 0 if clearing a non-container value.",

" * Returns 0 if no array or object value is located by the path.",
" * Always Returns 1 if clearing a JSON string value regardless of the length of the JSON string value including empty string.",

@sarthakaggarwal97 sarthakaggarwal97 Aug 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" * Always Returns 1 if clearing a JSON string value regardless of the length of the JSON string value including empty string.",
" *Returns 1 when clearing a JSON value.",

@roshkhatri roshkhatri Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it return the count of values, so this is incorrect.

@roshkhatri roshkhatri Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" * Always Returns 1 if clearing a JSON string value regardless of the length of the JSON string value including empty string.",

""
],
"JSON.DEBUG": [
Expand Down