POM validator - #1183
Open
toinehartman wants to merge 51 commits into
Open
POM validator#1183toinehartman wants to merge 51 commits into
toinehartman wants to merge 51 commits into
Conversation
…feature/add-pomxml-validator
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…validator' into feature/add-pomxml-validator
rodinaarssen
marked this pull request as ready for review
September 15, 2026 06:56
… quick fixes to for pom.xml files
|
DavyLandman
reviewed
Sep 22, 2026
Comment on lines
+96
to
+97
| var fallbackVersion = "2.22.5"; | ||
| return vf.string(fallbackVersion); |
Member
There was a problem hiding this comment.
How about we don't have a default? but throw an exception? as we really don't want to have this arb version in our code?
Comment on lines
+117
to
+120
| // This happens in second level | ||
| if (version == "Not specified") { | ||
| version = "0.43.0-RC14"; | ||
| } |
Member
There was a problem hiding this comment.
Shall we just insert ??? in there? as in most cases people won't be running this code in 2nd level with a snapshot dependency on rascal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.