Skip to content

Make the UDP port count configurable, non-zero by default #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xinix00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the UDP port count configurable, non-zero by default #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lneto.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ type LnetoConfig struct {
Hostname string
// MaxActiveTCPPorts is a heap-memory guardrail to limit number of simultaneous open TCP ports.
MaxActiveTCPPorts uint16
// MaxActiveUDPPorts is the same guardrail for UDP. Must be non-zero for a UDP socket to open.
MaxActiveUDPPorts uint16
// MaxListenerConns limits the amount of open [net.Listener] connections that can be established
// in simultaneous. Each newly allocated listener conn consumes 2*TCPBufferSize*MaxListenerConns so
// this can have drastic memory consumption impact.
Expand All @@ -55,6 +57,7 @@ func DefaultLnetoStackConfig() *LnetoConfig {
const tcpMaxSize = MTU - 20 - 20 // Do not consider IP+TCP headers.
return &LnetoConfig{
MaxActiveTCPPorts: 16,
MaxActiveUDPPorts: 4,
MaxListenerConns: 32, // Careful with number, large memory impact.
TCPBufferSize: 3 * tcpMaxSize, // 3× seems to work good on cyw43439.
TCPQueueSize: 8,
Expand Down Expand Up @@ -97,6 +100,7 @@ func NewLnetoStack(cfg *LnetoConfig) *LnetoStack {
ls := &LnetoStack{
hostname: cfg.Hostname,
maxTCPPorts: cfg.MaxActiveTCPPorts,
maxUDPPorts: cfg.MaxActiveUDPPorts,
maxListenerConns: cfg.MaxListenerConns,
tcpBufSize: cfg.TCPBufferSize,
tcpQueueSize: cfg.TCPQueueSize,
Expand All @@ -113,6 +117,7 @@ func NewLnetoStack(cfg *LnetoConfig) *LnetoStack {
type LnetoStack struct {
hostname string
maxTCPPorts uint16
maxUDPPorts uint16
maxListenerConns uint16
backoff lneto.BackoffStrategy // Determine poll duration for blocking operations.
backoffirq chan<- event
Expand All @@ -138,7 +143,7 @@ func (ls *LnetoStack) Configure(mac net.HardwareAddr, ip netip.Prefix, gw netip.
cfg := xnet.StackConfig{
RandSeed: int64(binary.LittleEndian.Uint64(rnd[:])),
MaxActiveTCPPorts: ls.maxTCPPorts,
MaxActiveUDPPorts: 0, // Unsupported as of yet.
MaxActiveUDPPorts: ls.maxUDPPorts,
Hostname: ls.hostname,
HardwareAddress: [6]byte(mac),
MTU: uint16(MTU),
Expand Down