(urql) - Fix subscription fetching lifecycle - #3902
Draft
zenios wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 6758b0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the documented
useSubscriptionfetching lifecycle:fetchingremainstruewhile the subscription source is active, including after payloadsfetchingbecomesfalsewhen the active source completesOperation results do not carry a React hook
fetchingfield, socomputeNextStatecurrently coerces the flag tofalseon every payload. Conversely, the completion handler uses!!source, but the configured source remains truthy after it has completed, causing completion to reporttrue.This restores the lifecycle originally discussed in #407 and implemented in #410 while retaining safe source replacement and Strict Mode behavior.
Set of changes
fetching: trueafter processing subscription payloads, preserving payload errorsfetching: falseon genuine upstream completiononEndis not interpreted as remote completionurqlThis is not a breaking change; it aligns runtime behavior with the existing
UseSubscriptionState.fetchingdocumentation.Validation
pnpm --filter urql test --run— 59 tests passedpnpm --filter urql checkpnpm --filter urql lintpnpm --filter urql buildpnpm changeset status