Word wrap - #27
Open
magnus-ISU wants to merge 5 commits into
Open
Conversation
…using word wrapping. Add ability to not do word wrapping
… deals with printing unicode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not going to merge this yet because it makes a potentially very undesirable change: It makes lolcat automatically wrap words. Words are defined as space-separated strings. So
prints
lolcatis about printing (fun) things for humans. So I think reflowing output is not necessarily a bad thing. But it may be very different from what is expected for a drop-in replacement for the originallolcat. Therefore it might be wiser to put it behind a-wflag to turn it on.However, I think also that making useful upgrades require random command-line flags to turn on is silly and a big part of why people love
ripgrepandbatandexaetc.I do think that the only output which this particularly breaks is probably already broken though. So I am in favor of it myself, just don't want to make such a change randomly.
Therefore, I am conflicted. I would like feedback on whether this should be merged or not. @ur0