Skip to content

Update action.yml to remove initial auth check #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyndyll wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update action.yml to remove initial auth check #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,21 +119,6 @@ runs:

shell: bash
run: |
response=$(curl -sSL -X POST \
--url "https://oauth.${{ inputs.upwind_uri }}/oauth/token" \
--data "audience=https://agent.${{ inputs.upwind_uri }}" \
--data "client_id=${{ inputs.upwind_client_id }}" \
--data "client_secret=${{ inputs.upwind_client_secret }}" \
--data "grant_type=client_credentials")

if ! TOKEN=$(echo "$response" | jq -r '.access_token // empty' 2>/dev/null); then
echo "Failed to parse JSON response: $response" >&2
exit 1
elif [ -z "$TOKEN" ]; then
echo "No access_token found in response: $response" >&2
exit 1
fi

@guybenh guybenh Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this block removed, is anything still setting $TOKEN? Line 148 below still sends Authorization: Bearer $TOKEN when downloading the agent binary, so unless the download endpoint no longer requires auth, this will now send an empty token and fail. If the endpoint is public now, should we drop the header too?

@tyndyll tyndyll Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoint doesn't require auth at all. It can be removed

OS=$(uname | tr '[:upper:]' '[:lower:]')
ARCH=$(uname -m | tr '[:upper:]' '[:lower:]')

Expand Down