feat(notifications): Discord embed for proposal.reviewed - #5
Merged
Conversation
Post approve/reject/needs-changes updates to #contributors when room-tba emits proposal.reviewed on admin review routes. Closes #4
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e5866809-b58c-4982-83a4-b5752f3cb9f1) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proposal.reviewedin Discord delivery →#contributorsTest plan
bun test src/notifications/notifications.test.tsproposal.reviewed→ embed in#contributorsCloses #4
Pairs with uplbtools/room-tba#222
Note
Low Risk
Additive notification path with no auth or ingress changes; low blast radius beyond new Discord messages in #contributors.
Overview
Adds
proposal.reviewedhandling so room-tba admin approve/reject/request-changes events post to#contributors, alongside existingproposal.submittednotifications.Discord delivery builds outcome-colored embeds (green approved, red rejected, amber needs-changes) with entity, submitter, reviewer, proposal ID, and an optional truncated editor note. Types add
ProposalReviewOutcomeandProposalReviewedPayload;docs/notifications.mddocuments the payload and routing.Coverage includes schema acceptance and
POST /notificationsforproposal.reviewed. Remaining diff is mostly formatting/import reordering.Reviewed by Cursor Bugbot for commit 7a1f783. Bugbot is set up for automated code reviews on this repo. Configure here.