chore: use Mono.Cecil 0.11.6

[jonpryor]

Context: #23966
Context: dotnet/macios#26428
Context: #24036
Context: dotnet/cecil#504
Context: jbevain/cecil#982
Context: jbevain/cecil@0.11.4...0.11.6
Context: jbevain/cecil@0.10.1...0.11.6

In The Beginning™ was a simple idea: why don't we have an iOS+Native AOT test stage? Thus began #23966, which promptly fell over, caught on fire, and sank into the swamp.

There are two issues with #23966:

1. CI was unhappy; it errors out with

   …/Xamarin.Shared.targets(2073,3): error : No valid iOS code signing keys found in keychain. You need to request a codesigning certificate from https://developer.apple.com.
   

   Not sure what's happening there. It doesn't happen locally…

2. It couldn't build locally either!

The initial attempt to build locally would fail in ilc:

# note: using changes from #23966
% TFM=net11.0-ios \
  NAOT=1 \
  BUILD_SOURCESDIRECTORY=`pwd` \
  BUILD_ARTIFACTSTAGINGDIRECTORY=`pwd`/artifacts \
  sh build/test-scripts/skia-ios-uitest-build.sh
…
    …/unoplatform/uno/src/SourceGenerators/Uno.UI.Tasks/Content/Uno.UI.Tasks.targets(487,3): warning Failed to resolve assembly `JetBrains.Annotations, Version=4242.42.42.42, Culture=neutral, PublicKeyToken=1010a0d8d6380325`: Failed to resolve assembly: 'JetBrains.Annotations, Version=4242.42.42.42, Culture=neutral, PublicKeyToken=1010a0d8d6380325'
    EXEC : error Sequence point value is out of range.
    $HOME/.nuget/packages/microsoft.dotnet.ilcompiler/11.0.0-preview.6.26359.118/build/Microsoft.NETCore.Native.targets(359,5): error MSB3073: The command ""$HOME/.nuget/packages/runtime.osx-arm64.microsoft.dotnet.ilcompiler/11.0.0-preview.6.26359.118/tools/ilc" @"obj/Release/net11.0-ios/ios-arm64/native/SamplesApp.ilc.rsp"" exited with code 1.

Thus began a fair bit of investigation, some of which is mentioned in #24036 and dotnet/cecil#504.

What happened was a "failure cascade":

1. The <Csc/> task produced a .pdb file.

2. Uno's <EmbeddedResourceInjectorTask_v0/> task would use Cecil to process the assembly and .pdb file from (1). Uno was using, at most, Mono.Cecil 0.11.4, which had a bug around the encoding of "compressed" integers within .pdb files.

   (This is later fixed in Add additional ByteBufferTest tests jbevain/cecil#982, and released as part of Mono.Cecil 0.11.6.)

   The updated .pdb file would contain "Invalid compressed integer" values.

3. Later, illink would run, which has it's own separate copy of Mono.Cecil -- from dotnet/cecil -- which would also update the .pdb files from (2). When illink ran, any "Invalid compressed integer" values would be further corrupted.

4. Later still, when ilc runs, it would process the .pdb files produced by (3), and at this point instead of "silently corrupting" data, it would error out entirely:

   Error: Sequence point value is out of range.
   System.BadImageFormatException: Sequence point value is out of range.
      at System.Reflection.Throw.SequencePointValueOutOfRange() in /_/src/runtime/src/libraries/System.Reflection.Metadata/src/System/Reflection/Throw.cs:line 239
      at System.Reflection.Metadata.SequencePointCollection.Enumerator.MoveNext() in /_/src/runtime/src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/PortablePdb/SequencePointCollection.cs:line 86
      at Internal.TypeSystem.Ecma.PortablePdbSymbolReader.<GetSequencePointsForMethod>d__10.MoveNext() in /_/src/runtime/src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/PortablePdbSymbolReader.cs:line 147
      at ILCompiler.Logging.MessageOrigin..ctor(MethodIL, Int32) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Logging/MessageOrigin.cs:line 65
   

(Failure cascades are fun!)

Part of the fix here is to update Uno to use Mono.Cecil 0.11.6, which contains the fix for reading and writing "compressed" integers in .pdb files. That is done here.

Additionally, I found it incredibly helpful in debugging all of this to have "before" and "after" versions of the files processed by <EmbeddedResourceInjectorTask_v0/>. (For too long, I thought that (3) was caused by a Roslyn bug, as I didn't see (2)!)

Update the <EmbeddedResourceInjectorTask_v0/> task so that it preseves the original assembly and .pdb files to have a .bk-EmbeddedResourceInjector extension, e.g.
SamplesApp.dll.bk-EmbeddedResourceInjector and
SamplesApp.pdb.bk-EmbeddedResourceInjector.

All of this will not fix #23966, but is a partial prerequisite. A full fix will require dotnet/cecil#504 to be merged and released, illink updated to use dotnet/cecil#504, and then there's dotnet/macios#26428, in which clang++ crashes when trying to link everything even if we get past the whole .pdb mess.

(Aside: the .pdb mess can be avoided by NOT USING .pdb FILES, e.g. buil with -p:DebugType=none. However, who wants to do that?)

…which still leaves the original "how do we get this building on CI" question…

Baby steps!

PR Type:

🏗️ Build or CI related changes

What changed? 🚀

PR Checklist ✅

• 🧪 Added Runtime tests, UI tests, or a manual test sample (for bug fixes / features, if applicable)
• 📚 Docs have been added/updated following the documentation template (for bug fixes / features)
• 🖼️ Validated PR Screenshots Compare Test Run results.
• ❗ Contains NO breaking changes
• 👀 Reviewed 2 other open pull requests (optional but appreciated!)

[Copilot]

Pull request overview

This PR updates Uno’s build-time tooling to consistently use Mono.Cecil 0.11.6 (to pick up the Portable PDB compressed-integer fix) and adds diagnostics to preserve “before” copies of assemblies/symbols processed by EmbeddedResourceInjectorTask_v0.

Changes:

• Bump Mono.Cecil package references across several validator/tools projects to 0.11.6.
• Update Uno.UI.Tasks to use Mono.Cecil 0.11.6.
• Add “pre-injection” backup copies (.bk-EmbeddedResourceInjector) for the target assembly and PDB in EmbeddedResourceInjectorTask_v0.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Uno.XamlTrimmingValidator/Uno.XamlTrimmingValidator.csproj	Update Mono.Cecil dependency to 0.11.6.
src/Uno.ResourceTrimmingValidator/Uno.ResourceTrimmingValidator.csproj	Update Mono.Cecil dependency to 0.11.6.
src/Uno.ReferenceImplComparer/Uno.ReferenceImplComparer.csproj	Update Mono.Cecil dependency to 0.11.6.
src/Uno.NUnitTransformTool/Uno.NUnitTransformTool.csproj	Update Mono.Cecil dependency to 0.11.6.
src/SourceGenerators/Uno.UI.Tasks/Uno.UI.Tasks.csproj	Update Mono.Cecil dependency to 0.11.6 for MSBuild task assembly.
src/SourceGenerators/Uno.UI.Tasks/EmbeddedResourceInjector/EmbeddedResourceInjectorTask.cs	Add backup copies of the pre-modified assembly/PDB prior to resource injection.

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[unodevops]

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-24050/wasm-skia-net9/index.html

[unodevops]

⚠️⚠️ The build 227085 has failed on Uno.UI - CI.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/SourceGenerators/Uno.UI.Tasks/Uno.UI.Tasks.csproj:20

• The PR description says it also updates EmbeddedResourceInjectorTask_v0 to preserve original assembly/PDB files with a .bk-EmbeddedResourceInjector extension, but there doesn't appear to be any corresponding code change in this PR. Please either update the PR description to match the actual changes, or include the intended backup behavior change in the diff.

		<PackageReference Include="Mono.Cecil" Version="0.11.6" />

src/Uno.XamlTrimmingValidator/Uno.XamlTrimmingValidator.csproj:10

• Per repo contribution requirements, the PR description should include a dedicated issue footer line like Fixes ... / Closes ... / Related to ... with the full issue URL. Right now it only lists the issue as a 'Context' link, which may not be picked up for tracking/auto-close.

  <ItemGroup>

[unodevops]

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-24050/wasm-skia-net9/index.html