feat(library): Add lighttpd 1.4 - #282
Open
vTusharr wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Unikraft “library” image definition for running lighttpd 1.4.82 via bincompat on an Alpine-based scratch rootfs, along with a dedicated GitHub Actions workflow to build/test/push the resulting OCI image.
Changes:
- Added
library/lighttpd/1.4.82with Kraftfile, rootfs Dockerfile, minimal lighttpd config, and a samplewwwroot/index.html. - Added a scheduled + PR/push CI workflow to build for
qemu/fcand smoke-test HTTP serving onqemu. - Added usage documentation for running the image with
kraft.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
library/lighttpd/1.4.82/wwwroot/index.html |
Adds a basic landing page served by lighttpd. |
library/lighttpd/1.4.82/README.md |
Documents how to run and curl the image. |
library/lighttpd/1.4.82/Kraftfile |
Defines the Unikraft build (elfloader template, lwIP, targets). |
library/lighttpd/1.4.82/Dockerfile |
Builds an Alpine-based scratch rootfs containing the lighttpd binary + runtime files. |
library/lighttpd/1.4.82/conf/lighttpd.conf |
Minimal config pointing to /wwwroot and using /tmp for uploads. |
.github/workflows/library-lighttpd1.4.82.yaml |
CI to build, test (HTTP smoke test), and push the image. |
Suppressed comments (2)
library/lighttpd/1.4.82/conf/lighttpd.conf:6
- Trailing whitespace in the comment line.
# Request-body temp dir
library/lighttpd/1.4.82/conf/lighttpd.conf:12
- The comment has inconsistent spacing (double spaces) and reads a bit oddly with "an" at the end of the line. Consider normalizing it.
# Content-Type is derived from lighttpd built-in defaults; an
# explicit mimetype.assign is only needed to override them.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@vTusharr , use present tense in the commit message. Use End period Use |
razvand
requested changes
Aug 2, 2026
razvand
left a comment
razvand
left a comment
Contributor
There was a problem hiding this comment.
See my comments.
Create a separate commit for the workflow. You will have to commits in this PR:
- Files to build and run Lighttpd with Unikraft
- The GitHub workflow YAML file
vTusharr
changed the title
vTusharr
changed the title
Add the definition for the `unikraft.org/lighttpd:1.4` image. Signed-off-by: Tushar Verma <tusharVermaiota@proton.me>
Add the build, push and runtime validation workflow for the lighttpd 1.4 Signed-off-by: Tushar Verma <tusharVermaiota@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a lighttpd 1.4 unikernel image (bincompat), built on Alpine since there is no official lighttpd Docker image. Also added related CI workflow