feat(library) -> Add nginx 1.31 - #280
Open
vTusharr wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Unikraft library image definition for unikraft.org/nginx:1.31, intended to provide an updated Nginx base (Alpine-based) and address the CVE mentioned in the PR description.
Changes:
- Introduces a new
library/nginx/1.31image definition (Kraftfile + scratch rootfs Dockerfile). - Adds a custom Nginx configuration (single-process, tokens off, gzip, basic security headers).
- Adds the default Nginx welcome page and a versioned README for running the image.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| library/nginx/1.31/wwwroot/index.html | Adds the default Nginx welcome page content. |
| library/nginx/1.31/README.md | Documents how to run/query the new unikraft.org/nginx:1.31 image. |
| library/nginx/1.31/Kraftfile | Defines the Unikraft build configuration and lwIP settings for Nginx 1.31. |
| library/nginx/1.31/Dockerfile | Builds a minimal scratch rootfs by copying Nginx + runtime deps from nginx:1.31.0-alpine. |
| library/nginx/1.31/conf/nginx.conf | Adds the Nginx runtime configuration for the image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Still waiting for WASP permissions to start the testing. @vTusharr In the meantime, please fix the issues mentioned by Copilot. Also, see my follow-up comment.
vTusharr
force-pushed
the
add_nginx-1.31
branch
2 times, most recently
from
June 21, 2026 15:18
cd969f7 to
5eff2f7
Compare
Author
|
@razvand gentle ping. |
razvand
requested review from
AndreiRV1 and
raresgoidescu
and removed request for
AndreiRV1
August 2, 2026 12:35
razvand
requested changes
Aug 2, 2026
razvand
left a comment
razvand
left a comment
Contributor
There was a problem hiding this comment.
Use a separate commit for the workflow.
Be sure to follow the commit best practices:
- Start with capital letter.
- Use present tense.
- Use a commit title and commit body.
- Sign your commit.
- Use the proper e-mail address for commit authorship and signature.
vTusharr
force-pushed
the
add_nginx-1.31
branch
from
August 4, 2026 14:10
5eff2f7 to
6d64e0c
Compare
vTusharr
changed the title
vTusharr
force-pushed
the
add_nginx-1.31
branch
2 times, most recently
from
August 7, 2026 15:37
1c6fe97 to
739ae68
Compare
Adds an nginx 1.31.0 image based on alpine as a base, modelled on the existing 1.25 image. Signed-off-by: Tushar Verma <tusharVermaiota@proton.me>
Add the build and push workflow for the `unikraft.org/nginx:1.31` image, and list the image in the top-level README table. Signed-off-by: Tushar Verma <tusharVermaiota@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an nginx 1.31.0 image based on alpine as a base , modelled on the existing 1.25 image.
circumventing CVE which is present in earlier version