Add functionality to include pages based on tags defined for test page. - #1368
Open
pwszpl wants to merge 4 commits into
Open
Add functionality to include pages based on tags defined for test page.#1368pwszpl wants to merge 4 commits into
pwszpl wants to merge 4 commits into
Conversation
fhoeben
requested changes
Oct 23, 2024
fhoeben
left a comment
fhoeben
left a comment
Collaborator
There was a problem hiding this comment.
Looks pretty good.
Sorry I didn't look at it earlier. Can you rebase on master and also add a line to the release notes page?
| import fitnesse.wiki.SymbolicPage; | ||
| import fitnesse.wiki.WikiPage; | ||
| import fitnesse.wiki.WikiPagePath; | ||
| import fitnesse.wiki.*; |
Collaborator
There was a problem hiding this comment.
Can you do explicit imports instead of .*? (Also for test class)
| WikiPageProperty suitesProperty = sourcePage.getData().getProperties().getProperty(WikiPageProperty.SUITES); | ||
| if (shouldIncludeTagLibraries() && suitesProperty != null){ | ||
| String[] tags1 = Arrays.stream(suitesProperty.getValue().split(",")).map(e -> e.trim()).filter(e -> checkIfTagIsNotReserved(e)).toArray(String[]::new); | ||
| for(int i=0;i<tags1.length;i++){ |
Collaborator
There was a problem hiding this comment.
Suggested change
| for(int i=0;i<tags1.length;i++){ | |
| for(int i = 0; i < tags1.length; i++){ |
| List<WikiPage> pages = new LinkedList<>(); | ||
| WikiPageProperty suitesProperty = sourcePage.getData().getProperties().getProperty(WikiPageProperty.SUITES); | ||
| if (shouldIncludeTagLibraries() && suitesProperty != null){ | ||
| String[] tags1 = Arrays.stream(suitesProperty.getValue().split(",")).map(e -> e.trim()).filter(e -> checkIfTagIsNotReserved(e)).toArray(String[]::new); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.