Feature/1152 - #1153
Open
micw wants to merge 2 commits into
Open
Conversation
added 2 commits
August 31, 2018 14:09
getRootPage()
provider for custom variables
Contributor
|
Hi Michael, Can you update the junit overview page to mention this new feature: |
fhoeben
reviewed
Nov 3, 2018
| } | ||
|
|
||
| protected WikiPage getRootPage() { | ||
| if (this.customVariables==null) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (this.customVariables==null) { | |
| if (this.customVariables == null) { |
| * @author mwyraz | ||
| */ | ||
| public interface CustomVariableProvider { | ||
| public Map<String,String> getCustomVariables(); |
Collaborator
There was a problem hiding this comment.
Should this method also receive the suiteClass?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotation based configuration of a provider class for custom variables. Solves #1152