Repository navigation
Fix typescript definitions - #33
Closed
MichaelBitard wants to merge 1 commit into
Closed
MichaelBitard wants to merge 1 commit into
MichaelBitard wants to merge 1 commit into
Conversation
MichaelBitard
commented
Mar 5, 2026
| */ | ||
| declare function take<T = any>( | ||
| n: number, | ||
| finalValue?: typeof none | typeof stop = none |
Author
There was a problem hiding this comment.
You cannot put a default value in a declare function
Owner
|
I confirmed the bug with the release version. I'll likely close this PR without merging, because the problems are mostly fixed in my private version among other changes. I'll keep it until the fix is merged. In any case thank you for the PR — it highlighted problems. |
Owner
|
Yeah, my changes broke the PR — closing as promised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #32
The main change is in tsconfig.json ("skipLibCheck": true should be false because it will skip all d.ts files 😢 )
Everything I did after this change was launching
npm run ts-checkand fix every error.