Conversation
The configs were renamed to c17v9/c22prev14/... in fdab666, but a number of default_config values (and two hardcoded training_configs) still referred to the old c17/l17 names. Any task that falls back to those defaults dies with ValueError: object 'l17' not known to index 'UniqueObjectIndex(cls=order.config.Config, len=10)' which is exactly what happens when following the README quickstart, since none of its law run examples pass --config. Rename the leftovers to c17v9/l17v9 and, while at it, fix the quickstart itself: pass an explicit --config, document that hbw.BuildCampaignSummary has to be run once per config before anything else (the lazy config factory refuses to build a config without it), and replace the config_2017/config_2017_limited paragraph with the list of configs that actually exist. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MdTWv3sC68nLDdYw12GV7K
artlbv
marked this pull request as draft
September 1, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Following the README quickstart on a fresh clone, every
law runcommand fails withThe configs were renamed to
c17v9/c22prev14/ ... in fdab666, but severaldefault_configvalues and two hardcoded
training_configsstill refer to the oldc17/l17names. Since noneof the quickstart commands pass
--config, they all fall back to those defaults.law.dl.nocert.cfgis the one that bites first, because it is the default answer forHBW_LAW_CONFIGinsetup.sh.Changes
Faithful rename of the leftovers,
c17→c17v9andl17→l17v9:law.cfg,law.shared.cfg,law.sl.cfg,law.sl.nocert.cfglaw.dl.nocert.cfg,law.resonant.nocert.cfgexamples/000_test/common.shnotebooks/setup.pyhbw/ml/old_ml_model.py,hbw/ml/derived/legacy_dl.pyAnd, so the quickstart actually runs end to end:
--configin the threelaw runexampleshbw.BuildCampaignSummaryhas to be run once per config first — the lazy configfactory in
hbw/analysis/create_analysis.pyinstantiates that task and refuses to build theconfig until its output exists, so without it every task fails with
"Campaign used for ... is not yet initialized"
--producers featuresfrom the plotting example (hbw.production.featuresis not inproduction_modulesany more)config_2017/config_2017_limitedparagraph with the list of configs that exist,and fix the dead link to
hbw/config/analysis_hbw.pyTesting
tests/run_lintingpasses. Verified separately that with these names the analysis resolves itsconfigs instead of raising, and that
hbw.BuildCampaignSummaryis indeed required before anythingelse.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MdTWv3sC68nLDdYw12GV7K