Proposal PR: Switch to vite-plus - #8151
Conversation
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedToo many files! This PR contains 406 files, which is 106 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (406)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Replace vite with vite-plus in demos and root packages - Update svelte, vite plugins, and typescript dependencies - Update vite.config.ts for vite-plus compatibility - Remove @vitest/ui from root devDependencies
- Remove restore-build action and artifact handling - Reorder pnpm store configuration in setup-env - Change build job dependencies to install-node-dependencies - Remove cache setting from publish workflow jobs
83927c0 to
2cc3d0a
Compare
Fixes
Changes and Review
This PR migrates the whole project from our individual setup (vite + vitest + tsup + oxc) to one solution using Vite+. A few pros and contras on why I would do this:
Pros
Cons
The review for this PR will be tough so the best to make sure this is valid:
One thing that this PR will also show is if the CI actions run correctly
extra note: the idea for this PR came from me trying out a new AI model and I thought a larger migration would be fun to test it on - keep that in mind in review.
Checklist
Responsibility