-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(static-renderer): close audio and video tags instead of self-closing #8138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lazerg
wants to merge
2
commits into
ueberdosis:main
Choose a base branch
from
lazerg:fix/issue-8130-audio-void
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tiptap/static-renderer': patch | ||
| --- | ||
|
|
||
| Render `audio` and `video` elements with a closing tag instead of as self-closing, so browsers no longer nest following content inside them. |
76 changes: 76 additions & 0 deletions
76
packages/static-renderer/__tests__/pm-self-closing-tags.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| import { Node } from '@tiptap/core' | ||
| import Document from '@tiptap/extension-document' | ||
| import Paragraph from '@tiptap/extension-paragraph' | ||
| import Text from '@tiptap/extension-text' | ||
| import { renderToHTMLString } from '@tiptap/static-renderer/pm/html-string' | ||
| import { describe, expect, it } from 'vitest' | ||
|
|
||
| const Audio = Node.create({ | ||
| name: 'audio', | ||
| group: 'block', | ||
| atom: true, | ||
| addAttributes() { | ||
| return { src: { default: null } } | ||
| }, | ||
| renderHTML({ HTMLAttributes }) { | ||
| return ['audio', HTMLAttributes] | ||
| }, | ||
| }) | ||
|
|
||
| const Video = Node.create({ | ||
| name: 'video', | ||
| group: 'block', | ||
| atom: true, | ||
| addAttributes() { | ||
| return { src: { default: null } } | ||
| }, | ||
| renderHTML({ HTMLAttributes }) { | ||
| return ['video', HTMLAttributes] | ||
| }, | ||
| }) | ||
|
|
||
| const extensions = [Document, Paragraph, Text, Audio, Video] | ||
|
|
||
| describe('static renderer: non-void elements get a closing tag', () => { | ||
| it('renders <audio> with a closing tag, not self-closed', () => { | ||
| const html = renderToHTMLString({ | ||
| content: { | ||
| type: 'doc', | ||
| content: [{ type: 'audio', attrs: { src: 'https://example.com/a.mp3' } }], | ||
| }, | ||
| extensions, | ||
| }) | ||
|
|
||
| expect(html).toBe('<audio src="https://example.com/a.mp3"></audio>') | ||
| }) | ||
|
|
||
| it('renders <video> with a closing tag, not self-closed', () => { | ||
| const html = renderToHTMLString({ | ||
| content: { | ||
| type: 'doc', | ||
| content: [{ type: 'video', attrs: { src: 'https://example.com/v.mp4' } }], | ||
| }, | ||
| extensions, | ||
| }) | ||
|
|
||
| expect(html).toBe('<video src="https://example.com/v.mp4"></video>') | ||
| }) | ||
|
|
||
| it('keeps multiple audio players as siblings instead of nesting them', () => { | ||
| const html = renderToHTMLString({ | ||
| content: { | ||
| type: 'doc', | ||
| content: [ | ||
| { type: 'audio', attrs: { src: 'https://example.com/a.mp3' } }, | ||
| { type: 'paragraph', content: [{ type: 'text', text: 'between' }] }, | ||
| { type: 'audio', attrs: { src: 'https://example.com/b.mp3' } }, | ||
| ], | ||
| }, | ||
| extensions, | ||
| }) | ||
|
|
||
| expect(html).toBe( | ||
| '<audio src="https://example.com/a.mp3"></audio><p>between</p><audio src="https://example.com/b.mp3"></audio>', | ||
| ) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,8 @@ const NON_SELF_CLOSING_TAGS = new Set([ | |
| 'span', | ||
| 'a', | ||
| 'button', | ||
| 'audio', | ||
| 'video', | ||
| ]) | ||
|
|
||
| /** | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.