chore: unpin bazzite - #264
Open
renner0e wants to merge 1 commit into
Open
Conversation
While it is probably a good idea to pin this to a digest and setup renovate in the repo of the user to only build the image when the tag actually has received an update, instead of scheduling a build daily which results in useless rebuilds with no real changes as Bazzite (which I'm guessing is the most popular image) only updates week/bi-weekly'ish. Renovate also doesn't currently update this image so sooner or later this image will get cleaned up and the builds here in the template will fail. I'm not sure why exactly this got pinned, auto-approved and auto-merged in the first place in ffec79a by our hosted renovate. IIRC there were some org-wide changes regarding that so that might be why? If this was just a one-off thing then this is likely good enough to resolve it, if not then this probably needs a follow-up of some kind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it is probably a good idea to pin this to a digest and setup renovate in the repo of the user to only build the image when the tag actually has received an update, instead of scheduling a build daily which results in useless rebuilds with no real changes as Bazzite (which I'm guessing is the most popular image) only updates week/bi-weekly'ish.
Renovate also doesn't currently update this image so sooner or later this image will get cleaned up and the builds here in the template will fail.
I'm not sure why exactly this got pinned, auto-approved and auto-merged in the first place in ffec79a by our hosted renovate.
IIRC there were some org-wide changes regarding that so that might be why?
If this was just a one-off thing then this is likely good enough to resolve it, if not then this probably needs a follow-up of some kind.