feat: make rpm-ostree use containers-storage over oci-archive - #263
Conversation
renner0e
left a comment
renner0e
left a comment
There was a problem hiding this comment.
really nice improvement overall, thanks for looking into this
seems to have gone down from 11m to 8m
https://github.com/ublue-os/image-template/actions/runs/32125672094
https://github.com/ublue-os/image-template/actions/runs/32141474535
| --mount=type=image,src="${target_image}:${tag}",target=/rpm-ostree \ | ||
| --privileged \ | ||
| -v "${RPM_OSTREE_OUTPUT_DIR}:/run/out:Z" \ | ||
| --mount=type=bind,src=/home/runner/.local/share/containers/storage,target=/run/host-container-storage,rw \ |
There was a problem hiding this comment.
this hardcodes github's runner specific paths and wouldn't work locally, we need to determine it beforehand
this is likely what we want
podman info --format '{{ .Store.GraphRoot }}'
| --mount=type=bind,src=/home/runner/.local/share/containers/storage,target=/run/host-container-storage,rw \ | ||
| --mount=type=tmpfs,target=/run/rpm-ostree-storage \ | ||
| --entrypoint /usr/bin/rpm-ostree \ | ||
| "${RPM_OSTREE_CHUNKER_IMAGE}" \ |
There was a problem hiding this comment.
small nit, I like that we specify the image we use for rechunking with the variable above, the use case for this might be using a separate image which ships a newer/older rpm-ostree, just seems a little cleaner to me
There was a problem hiding this comment.
Forgot to revert that after my testing.
Co-authored-by: renner <80410025+renner0e@users.noreply.github.com>
2 participants
Improves build performace on #261 by writing the image layers directly to the host container store instead of compressing to an OCI archive then decompressing before pushing to the registry.