'True' normalisation, and some Hist2D colorbar changes - #8
Open
naidoo88 wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Nick,
Wanted to pass along a couple of changes I've made.
Hist1D
I've added the calculation for a 'true' normalization (area under the histogram = 1), mirroring matplotlib's definition of
density. So as to not interfere with any legacy code, I have called thisdensity_norm. I have also leftdensityas the default, but whendensity_normis used, it supersedes this default behavior, with a warning message to let the user know thatdensityhas been disabled.Further to this, I have included the uncertainty calculations for both
densityanddensity_norm. If noerrorcalcis specified, butdensityordensity_normare used, the correct error calculation is automatically selected.Hist2D
In order to be able to do some 'after the fact' colorbar tweaks the
colorbaris now an object of the class. e.g, after plotting the Hist2D object:Further to this, to enable more control over the colorbar, I have added a 'kwargs' variable
colorbar_params.To preserve your default styling, the colorbar
aspectis set to 20 when nocolorbar_paramsargument is provided.