-
Notifications
You must be signed in to change notification settings - Fork 61
feat(minibf): add /governance/proposals/*/metadata routes
#1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bdc05f4
feat(minibf): add `/governance/proposals/*/metadata` routes
michalrus d75efa8
fix(formatting): comments on `+nightly`
michalrus 0dfe032
fix(minibf): harden the governance metadata fetch
michalrus 8506404
fix(minibf): reject Bech32m governance action IDs
michalrus 9240db0
fix(minibf): return 400 for an out-of-range proposal cert_index
michalrus 29bbdf2
Merge branch 'main' into feat/minibf-governance-proposals-metadata
michalrus 8a585f8
chore(minibf): use `Error::InvalidGovActionId` for governance metadata
michalrus 3e1f00b
feat(minibf): resolve `ipfs://` governance anchors through gateways
michalrus e96ecd0
fix(minibf): reuse the client for governance metadata
michalrus 882b426
fix(formatting): for `+nightly`
michalrus 0cbc89d
fix(minibf): off-by-one error around `MAX_ANCHOR_REDIRECTS`
michalrus fd3db02
test(minibf): cover anchor hash and JSON errors
michalrus cb86ce3
test(minibf): cover valid anchor metadata
michalrus 6e486f6
Merge branch 'main' into feat/minibf-governance-proposals-metadata
michalrus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.