ci(codegen): compile java and swift clients against published SDKs - #366
Merged
Merged
Conversation
land.tx3:tx3-sdk:0.15.0 is on Maven Central and swift-sdk v0.15.0 is tagged, so drop the pinned-commit stand-ins: the generated Maven project resolves 0.15.0 from Central with the runner's Maven, and the generated SwiftPM package resolves the published tag directly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
java-clientandswift-clientcompile checks built against pinned SDK commits (java-sdkd7a6dc4as0.15.0-SNAPSHOT; swift-sdk02fa0f2through a locally tagged SwiftPM mirror) because the SDKs had no release. Both are now published:land.tx3:tx3-sdk:0.15.0on Maven CentralChange
Remove both stand-in blocks and the
-Dtx3.sdk.version/ mirror overrides. The rendered projects now build exactly as generated: Java resolves the template'stx3.sdk.version(0.15.0) from Central using the runner's Maven (the generated project has no wrapper;ubuntu-latestships Maven), and Swift resolvesfrom: "0.15.0"from the public tag. The script header's "compiles against the published SDK release" is accurate again.Verification
codegen-compile-check.sh swift-clientresolvedswift-sdkat 0.15.0 and built bothtransferandcomplexfixtures.java-client: no local JDK; relies on this PR'scodegen compile (java-client)job.bash -npasses.🤖 Generated with Claude Code