Skip to content

Return Basic auth challenges instead of 500 (Allows use of Git credential helpers) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasantony wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return Basic auth challenges instead of 500 (Allows use of Git credential helpers) #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions _worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,22 @@ async function sign(s3, bucket, path, method) {
function parseAuthorization(req) {
const auth = req.headers.get("Authorization");
if (!auth) {
throw new Response(null, { status: 401 });
return new Response(null, {
status: 401,
headers: { "WWW-Authenticate": 'Basic realm="Git LFS"' },
});
}

const [scheme, encoded] = auth.split(" ");
if (scheme !== "Basic" || !encoded) {
throw new Response(null, { status: 400 });
return new Response(null, { status: 400 });
}

const buffer = Uint8Array.from(atob(encoded), (c) => c.charCodeAt(0));
const decoded = new TextDecoder().decode(buffer);
const index = decoded.indexOf(":");
if (index === -1) {
throw new Response(null, { status: 400 });
return new Response(null, { status: 400 });
}

return { user: decoded.slice(0, index), pass: decoded.slice(index + 1) };
Expand Down Expand Up @@ -65,7 +68,11 @@ async function fetch(req, env) {
return new Response(null, { status: 406 });
}*/

const { user, pass } = parseAuthorization(req);
const authorization = parseAuthorization(req);
if (authorization instanceof Response) {
return authorization;
}
const { user, pass } = authorization;
let s3Options = { accessKeyId: user, secretAccessKey: pass };

const segments = url.pathname.split("/").slice(1, -2);
Expand Down