[codex] Fix lazygit shortcut in nested terminals - #532
Merged
Merged
Conversation
|
@shlroland is attempting to deploy a commit to the Faberon Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@shlroland Merged as Nightly: https://github.com/tw93/Kaku/releases/download/nightly/Kaku-nightly.dmg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #531.
Cmd+Shift+Gcould showLazygit: Not a git repositoryeven when the current interactive Fish shell had already entered a valid Git repository withziorcd. The problem is not specific to Herdr or tmux: Kaku's cached/OSC 7 pane cwd can lag behind the shell's real$PWD, so the old Git preflight checked the wrong directory and blocked dispatch.The shortcut still belongs to Kaku, but it now checks only that lazygit is installed and sends
Ctrl+U + lazygit + Enterto the current terminal input stream. The receiving shell or multiplexer resolves the command using its actual focused-pane$PWD. If that directory is not a Git repository, lazygit reports the native error itself.Changes
launch_lazygit.Validation
cargo test -p configmake fmt-checkmake appluajit -e "assert(loadfile('assets/macos/Kaku.app/Contents/Resources/kaku.lua'))"Manual verification
zito enter a Git repository.pwdandgit statusshow the repository.The same flow also covers Herdr and tmux nested panes.