Wait for system startup only once - #93
Open
lirazsiri wants to merge 1 commit into
Open
Conversation
The firstboot runner currently repeats its ten-second systemd startup wait before every hook numbered 30 or later. Because inithooks.service itself keeps systemd in the starting state, cloud initialization pays the full delay repeatedly even when security updates take only a few seconds. Remember when the startup wait has run and continue through the remaining hooks without repeating it. A mocked runner check confirms one ten-call wait across multiple late firstboot hooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firstboot runner currently repeats its ten-second systemd startup wait before every hook numbered 30 or later. On a Hub-launched v19 WordPress instance this produced 150 wait messages and made
inithooks.servicetake 3 minutes 14 seconds, although the security update hook itself took only 3 seconds.This change records that the startup wait has run and continues through the remaining firstboot hooks without repeating it. That matches the intent of ca386af (
only wait once we get to 30xxx).Verification:
bash -n rungit diff --check01,30,40) observed exactly one ten-call wait