Repository navigation
feat: new explore layout, filter redesign, EAT panel and dark mode - #555
Draft
peymanvahidi wants to merge 489 commits into
Draft
peymanvahidi wants to merge 489 commits into
peymanvahidi wants to merge 489 commits into
Conversation
Also wraps the figure editor's tool row on phones.
Collaborator
Author
|
A review pass fixed 26 small issues: EAT filter undo and Dim saving, filter value counts inside groups, touch targets, keyboard focus, and a legend drag bug. All unit, end-to-end and performance checks pass. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new layout for the explore page: a top bar, a toolbar above the plot, and a sidebar on the right with the legend, filters, EAT and 3D structure. The sidebar can be folded away. The plot now fills the space it has.
Also in this PR:
mainnow sits in the new Export menu (under More on phones).Builds on #526: merge that first. Use a merge commit, not squash.
Tests: unit, end-to-end (desktop and phone) and performance checks pass.
Follow-ups (not in this PR): a few large source files still need splitting, the core package's unit tests are not type-checked, and part of the legend code mixes row actions with sorting.