[INF-7324] (opt-in) hpa for jse deployment - #363
Open
lukefoster11 wants to merge 8 commits into
Open
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| charts/retool/templates/deployment_js_executor.yaml | Adds the gated JS executor HPA, matching-request validation, and conditional omission of Deployment replicas. |
| charts/retool/values.yaml | Adds the chart’s public JS executor autoscaling defaults and configuration guidance. |
| values.yaml | Keeps the repository-level values copy synchronized with the deployable chart defaults. |
| charts/retool/ci/test-js-executor-hpa-option.yaml | Adds a fixture covering HPA rendering, CPU and memory targets, replica ownership, and scaling behavior. |
| charts/retool/Chart.yaml | Increments the chart patch version for the new opt-in feature. |
Reviews (6): Last reviewed commit: "simplify" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
lukefoster11
changed the title
Contributor
Author
|
@greptile review me again |
Contributor
Author
|
@greptile review me again pls |
Contributor
Author
|
@greptile can you review again |
Contributor
Author
|
@greptile review me again pls |
lukefoster11
marked this pull request as ready for review
August 18, 2026 20:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easy to enable hpa for the js-executor deployment. Scale on 70% mem and 70% cpu usage.
Ask from Colgate