Feature: defmt support - #137
Conversation
robin-nitrokey
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have two requests:
- Ideally features should be additive. Currently, enabling
defmtdisablesdelog. Do you see a way to supportdefmtanddelogindependent of each other? Maybe with a custom macro that dispatches todefmtand/ordelogbased on the features? - To avoid the duplication in the
Debuganddefmt::Formatimplementation forError, I think it would make sense to have apub const fn as_str(&self) -> Option<&'static str>that is used by both.
|
Thank you for your review. Strings written within the However, if I move the strings to another function, the strings are included in the logging data. By defining Error as an enum, we can use |
|
I see, thanks for the explanation. Please add a short comment with what you just wrote to the We deliberately don’t have |
robin-nitrokey
left a comment
There was a problem hiding this comment.
I think you ended up using debug! instead of debug_lib! in some lines.
No description provided.