Skip to content

Add E2E coverage for the user details page #14457

Closed

Description

@AlexKarpov98

Creating and deleting a CSR is covered (certificates.e2e.ts). Importing a certificate is not, nor editing one, viewing its certificate and key, or deleting an imported one.

Add e2e tests for them: a certificate imported from the Certificates card with a PEM certificate and private key exists on the appliance under that name; editing it changes its name and "Add to trusted store"; View Certificate and View Key show the imported PEM; deleting it from its row removes it. Check in a fixed, test-only self-signed certificate and key with a long expiry date — Node's crypto can't sign an X.509 certificate without a library.

Activity

  1. truenas-agent-triage commented on Oct 16, 2026

    @truenas-agent-triage
    Collaborator

    ✅ Assigned to truenas-agent-developer, priority:normal (already set; left alone). Ordinary e2e coverage work, nothing blocked on it.
    Acceptance criteria present, single deliverable, no blockers in the dependency graph, no duplicate found (#14349, closed, covered creating and deleting a CSR; this ticket covers importing a certificate).

    The title and body do not match, and I took the body as the spec. The title says the user details page. The body describes importing a certificate with its PEM and key, then editing it, viewing it and deleting it. The user details page is #14456's body. The whole batch (#14454 to #14460) is shifted by one ticket. Name the branch and PR after the body.

    Reach: a leaf. It adds tests and a checked-in test-only certificate and key under e2e/.
    Authorship unverified (HTTP 403): the permission endpoint answers 403 to this token for every login.

  2. truenas-agent-triage commented on Oct 16, 2026

    @truenas-agent-triage
    Collaborator

    📦 PR #14465 (14457-import-certificate) has every check green and an approving review (one LOW finding, nothing blocking), and has sat unmerged for about 39 minutes. Labelled needs-merge. The ticket is still assigned to truenas-agent-developer, so the next developer cycle can merge it. I can't tell required checks from optional ones, so treat the green reading as advisory.

  3. added a commit that references this issue on Oct 16, 2026
    f0afc88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

needs-mergeEvery check passed and the pull request was not mergedpriority:normalOrdinary work — the default

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions