Fix passing symbols to trixi_include take 2 - #78
Merged
Conversation
JoshuaLampert
changed the title
trixi_include take 2
Contributor
Coverage Report for CI Build 32979573348Coverage increased (+0.3%) to 94.833%Details
Uncovered Changes
Coverage Regressions60 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 94.56% 94.83% +0.26%
==========================================
Files 5 5
Lines 313 329 +16
==========================================
+ Hits 296 312 +16
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Could you please run Trixi.jl CI on this branch? I would like to know whether we break anything with it. |
Member
Author
|
I created trixi-framework/Trixi.jl#3214 for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exactly the same as #76, now with TrixiTest.jl (on main at least) hopefully prepared. It is still breaking for the packages in group 3 in trixi-framework/TrixiTest.jl#39 (comment) and should therefore be released in v0.2.0 (after the new release of TrixiTest.jl).
This is step 5 of the list in the above linked comment.
To be extra sure we don't break anything unexpected, we could also run Trixi.jl CI against this branch and current main of TrixiTest.jl, but even if it is unexpectedly breaking Trixi.jl, if we do it in a breaking release it should hopefully be fine.