Skip to content

Add downstream test for TrixiTest.jl - #77

Merged
ranocha merged 2 commits into
mainfrom
downstream-test
Aug 26, 2026
Merged

Add downstream test for TrixiTest.jl#77
ranocha merged 2 commits into
mainfrom
downstream-test

Conversation

@JoshuaLampert

Copy link
Copy Markdown
Member

Since #76 accidentally broke TrixiTest.jl (and therefore other downstream packages), I thought it might be a good idea to run downstream tests here to catch errors like this earlier and avoid releasing version that break tests. We could also run downstream tests for Trixi.jl, but I think with the tests of TrixiTest.jl we should usually catch most issues and the tests of Trixi.jl would take much longer.

@ranocha ranocha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert

Copy link
Copy Markdown
Member Author

As I wrote in trixi-framework/TrixiTest.jl#38 (comment), it is unfortunately not quite true that succeeding tests in TrixiTest.jl can give us confidence that the tests in Trixi.jl do not fail because of changes in TrixiBase.jl/TrixiTest.jl. So should we add more downstream tests here? Either a representative part of Trixi.jl's tests (tree_part1 and misc_part1 failed due to the recent TrixiBase.jl update) or the upstream tests of TrixiShallowWater.jl (also failed), or another repo?

@ranocha

ranocha commented Aug 25, 2026

Copy link
Copy Markdown
Member

Can we add tests to TrixiTest.jl that would fail in the same way as tests in Trixi.jl failed with the new version of TrixiBase.jl?

@JoshuaLampert

Copy link
Copy Markdown
Member Author

Good idea. I'll look into it.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.56%. Comparing base (c01f1c4) to head (3591e5c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files           5        5           
  Lines         313      313           
=======================================
  Hits          296      296           
  Misses         17       17           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

coveralls commented Aug 25, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 32878883622

Coverage remained the same at 94.569%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 48 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

48 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
test/trixi_include.jl 44 77.08%
src/TrixiBase.jl 3 0.0%
src/trixi_timeit.jl 1 83.33%

Coverage Stats

Coverage Status
Relevant Lines: 313
Covered Lines: 296
Line Coverage: 94.57%
Coverage Strength: 115.65 hits per line

💛 - Coveralls

@ranocha
ranocha enabled auto-merge (squash) August 25, 2026 19:14
@ranocha
ranocha merged commit d24a173 into main Aug 26, 2026
13 checks passed
@ranocha
ranocha deleted the downstream-test branch August 26, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants