Add downstream test for TrixiTest.jl - #77
Conversation
|
As I wrote in trixi-framework/TrixiTest.jl#38 (comment), it is unfortunately not quite true that succeeding tests in TrixiTest.jl can give us confidence that the tests in Trixi.jl do not fail because of changes in TrixiBase.jl/TrixiTest.jl. So should we add more downstream tests here? Either a representative part of Trixi.jl's tests ( |
|
Can we add tests to TrixiTest.jl that would fail in the same way as tests in Trixi.jl failed with the new version of TrixiBase.jl? |
|
Good idea. I'll look into it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 5 5
Lines 313 313
=======================================
Hits 296 296
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Coverage Report for CI Build 32878883622Coverage remained the same at 94.569%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions48 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
Since #76 accidentally broke TrixiTest.jl (and therefore other downstream packages), I thought it might be a good idea to run downstream tests here to catch errors like this earlier and avoid releasing version that break tests. We could also run downstream tests for Trixi.jl, but I think with the tests of TrixiTest.jl we should usually catch most issues and the tests of Trixi.jl would take much longer.