Skip to content

allow v0.2 of TrixiBase.jl - #3215

Merged
ranocha merged 1 commit into
mainfrom
hr/allow_TrixiBase_02
Aug 27, 2026
Merged

allow v0.2 of TrixiBase.jl#3215
ranocha merged 1 commit into
mainfrom
hr/allow_TrixiBase_02

Conversation

@ranocha

@ranocha ranocha commented Aug 27, 2026

Copy link
Copy Markdown
Member

@ranocha
ranocha requested a review from JoshuaLampert August 27, 2026 07:24
@github-actions

Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@ranocha
ranocha enabled auto-merge (squash) August 27, 2026 08:03
@JoshuaLampert
JoshuaLampert disabled auto-merge August 27, 2026 08:13
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.95%. Comparing base (630c6ee) to head (52a9e90).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3215   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files         673      673           
  Lines       52160    52160           
=======================================
  Hits        50570    50570           
  Misses       1590     1590           
Flag Coverage Δ
unittests 96.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaLampert

Copy link
Copy Markdown
Member

This cannot be auto-merged because the whitespace check is required, but does not run on changes not affecting any source files. So this needs a force-merge.

@ranocha
ranocha merged commit 865c27f into main Aug 27, 2026
41 checks passed
@ranocha
ranocha deleted the hr/allow_TrixiBase_02 branch August 27, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants