Skip to content

Update tablesort.js #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tristen merged 5 commits into from
Dec 26, 2025
Merged

Update tablesort.js #183

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75dfbad
Update tablesort.js
yukulele Feb 24, 2020
3126f6e
Update tablesort.js
yukulele Feb 24, 2020
e09912c
Update tablesort.js
yukulele Feb 24, 2020
3bf7ea9
Merge branch 'master' into patch-1
tristen Dec 26, 2025
438c267
Apply suggestion from @tristen
tristen Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/tablesort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,13 @@

return evt;
};

var getInnerText = function(el,options) {
return el.getAttribute(options.sortAttribute || 'data-sort') || el.textContent || el.innerText || '';

var getInnerText = function(el, options) {
var sortAttribute = options.sortAttribute || 'data-sort';
if(el.hasAttribute(sortAttribute)) {
Comment thread
tristen marked this conversation as resolved.
Resolved
return el.getAttribute(sortAttribute);
}
return el.textContent || el.innerText || '';
};

// Default sort method if no better sort method is found
Expand Down