feat: add automatic config reload polling - #1067
Open
houyuwushang wants to merge 2 commits into
Open
Conversation
jranson
requested changes
Jul 17, 2026
houyuwushang
force-pushed
the
feat/auto-config-reload-904
branch
from
July 24, 2026 14:20
7faea96 to
f6d983c
Compare
Contributor
Author
|
@jranson, could you re-review this when you get a chance? The requested configuration-key and empty-path changes are addressed, and the branch is rebased onto current |
Member
|
We're targeting this for the v2.1.0 release, so I'll give it a final review once v2.0.5 release (which includes the new aggregation items from #1068) lands |
Signed-off-by: houyuwushang <liuluoqianqiu@outlook.com>
Signed-off-by: houyuwushang <liuluoqianqiu@outlook.com>
houyuwushang
force-pushed
the
feat/auto-config-reload-904
branch
from
August 1, 2026 07:52
f6d983c to
f6e64f0
Compare
Contributor
Author
|
@jranson v2.0.5 is out now. I rebased this onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #904.
Adds opt-in configuration polling through
mgmt.auto_reload_interval. The watcher checks file staleness before invoking the existing graceful reload path, so unchanged polls do not increment reload-attempt metrics or engage the reload rate limiter. A successful reload publishes the new configuration back to the watcher, allowing the interval to be changed or disabled without restarting Trickster.The default remains
0s(disabled), negative intervals are rejected, and the projected-volume test covers thetrickster.yaml -> ..data/trickster.yamlsymlink swap used by Kubernetes ConfigMaps. The configuration examples now also use the currentmgmtsection and reload field names.Validation:
go vet ./pkg/config/... ./pkg/daemonand incrementalgolangci-lint0sinterval prevented a subsequent change from reloadingType of Change
AI Disclosure