Skip to content

(new) VertxInputStream - #61

Open
trajano wants to merge 4 commits into
masterfrom
remove-blocking-input-stream
Open

(new) VertxInputStream#61
trajano wants to merge 4 commits into
masterfrom
remove-blocking-input-stream

Conversation

@trajano

@trajano trajano commented Mar 9, 2018

Copy link
Copy Markdown
Owner

No description provided.

trajano
trajano commented Mar 10, 2018
View reviewed changes
Comment thread ms-engine/src/main/java/net/trajano/ms/engine/internal/VertxInputStream.java
*/
public void end() {

System.out.println("ended");

@trajano trajano Mar 10, 2018

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this use of System.out or System.err by a logger. rule

trajano
trajano commented Mar 10, 2018
View reviewed changes
Comment thread ms-engine/src/main/java/net/trajano/ms/engine/internal/VertxInputStream.java
readStream.pause();
} else {
if (streamSemaphore.availablePermits() > 1) {
throw new RuntimeException("p=" + streamSemaphore.availablePermits());

@trajano trajano Mar 10, 2018

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Define and throw a dedicated exception instead of using a generic one. rule

trajano
trajano commented Mar 10, 2018
View reviewed changes
Comment thread ms-engine/src/main/java/net/trajano/ms/engine/internal/VertxInputStream.java
*/
public class VertxInputStream extends InputStream {

private static final Logger LOG = LoggerFactory.getLogger(VertxInputStream.class);

@trajano trajano Mar 10, 2018

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Remove this unused "LOG" private field. rule

trajano
trajano commented Mar 10, 2018
View reviewed changes
Comment thread ms-engine/src/main/java/net/trajano/ms/engine/internal/VertxInputStream.java
*/
public void populate(final Buffer buffer) {

System.out.println("populating..." + currentBuffer != null);

@trajano trajano Mar 10, 2018

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this use of System.out or System.err by a logger. rule

@trajano

trajano commented Mar 10, 2018

Copy link
Copy Markdown
Owner Author

SonarQube analysis reported 4 issues

  • MAJOR 4 major

Watch the comments in this conversation to review them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@trajano