Conversation
trajano
force-pushed
the
jaxrs-2.1
branch
4 times, most recently
from
March 1, 2018 14:24
c69f5e4 to
de1cd2c
Compare
trajano
force-pushed
the
master
branch
16 times, most recently
from
March 3, 2018 02:45
abd8e9c to
6bfd4af
Compare
trajano
force-pushed
the
jaxrs-2.1
branch
2 times, most recently
from
March 7, 2018 16:13
bf9652b to
439776a
Compare
trajano
commented
Mar 9, 2018
|
|
||
| final Map<String, Set<ConstraintViolation<Object>>> violationMap = new LinkedHashMap<>(); | ||
| boolean hasViolation = false; | ||
| for (int i = 0; i < method.getParameterCount(); ++i) { |
Owner
Author
There was a problem hiding this comment.
trajano
commented
Mar 9, 2018
| final boolean showStackTrace) { | ||
|
|
||
| super(e, uriInfo, showStackTrace); | ||
| violations = StreamSupport.stream(e.getConstraintViolations().spliterator(), false).map(v -> new ConstraintViolationElement(v)).collect(Collectors.toList()); |
Owner
Author
There was a problem hiding this comment.
Use the new version of spring boot. This will change the SPI because Spring boot now uses Class<?>[] to boostrap rather than Object[]. It also upgrades Mockito to 2.x which requires an additional test scope library for Vert.X mock testing.
Removes deprecation
Versions that are part of the spring-boot are used. Added additional support for JSON-B.
Used ArgumentMatchers
Introduces the use of Bean Validation API to validate the input data. A custom ExceptionMapper and response structure is used to show the error. The sample also adds a validation annotated bean for testing. The exception mapper logging now goes to net.trajano.ms.MicroService rather than individual ones.
BVal is not used and Hibernate Validator is used instead as it is the only one that supports Bean Validation 2.0 right now.
Owner
Author
|
SonarQube analysis reported 5 issues
Watch the comments in this conversation to review them. 3 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use REST Easy 4.0.0.Beta2 to prepare for JAX-RS 2.1
When released bump to version 2.0.0 of the app-ms
Remove deprecated code as well.