Repository navigation
Fix Linode teardown without deployment prerequisites - #15081
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linode teardown currently runs deployment prompts, so missing local SSH keys or a failed regions request prevents deletion. Extract the existing token gathering into
auth.ymland call it directly during teardown. Deployment still reads its region and public key.Add eight regression cases that run the production playbook with the real Linode module and SDK against a local HTTP fixture. They cover variable and environment credentials, unavailable regions, missing SSH keys, an already-absent instance, rejected deletion preserving client files, the confirmation gate, and unchanged deployment setup.
Validation: 43 focused tests and all 18 prek hooks passed. Restoring the old teardown routing made all four key/region regression cases fail. No cloud resources were created.