Skip to content

fix(writer): accept writer-sdk 3.x in the dependency check #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(writer): accept writer-sdk 3.x in the dependency check #4410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ges/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

logger = logging.getLogger(__name__)

_instruments = ("writer-sdk >= 2.2.1, < 3",)
_instruments = ("writer-sdk >= 2.2.1, < 4",)

@coderabbitai coderabbitai Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Update the package dependency metadata to allow writer-sdk 3.x.

Line 40 allows writer-sdk versions below 4, but packages/opentelemetry-instrumentation-writer/pyproject.toml:43 still declares writer-sdk>=2.3.0,<3. A standard resolver can therefore reject or downgrade writer-sdk==3.0.0 before BaseInstrumentor.instrument() runs. Change the package dependency upper bound to <4, while keeping any test-only <3 constraint separate if required.

Proposed metadata change 
- "writer-sdk>=2.3.0,<3",
+ "writer-sdk>=2.3.0,<4",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/__init__.py`
at line 40, Update the package dependency declaration in pyproject.toml
associated with the writer instrumentation to allow writer-sdk versions from
2.3.0 up to, but not including, 4. Keep any test-only constraint below version 3
separate if needed, and leave the _instruments declaration unchanged.


WRAPPED_METHODS = [
{
Expand Down