Repository navigation
fix[truncate]: escape string separator in RegExp - #2130
Open
TalhaHunter101 wants to merge 1 commit into
Open
TalhaHunter101 wants to merge 1 commit into
TalhaHunter101 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2129
When
options.separatoris a string containing RegExp metacharacters (such as?,+,*,[,(,.,\),truncateines-toolkit/compatdirectly interpolates it intonew RegExpwithout escaping. This causesSyntaxError: Invalid regular expressioncrashes when the separator contains quantifiers or unclosed brackets, and unintended wildcard behavior for..Difference from Lodash
With this change,
truncateescapes string separators usingescapeRegExp, matching Lodash's behavior and preventing regex syntax crashes.Changes
separatorwithescapeRegExpbefore building the truncation RegExp.src/compat/string/truncate.spec.tscovering string separators containing RegExp metacharacters (?,[,(,+,*,., and\).