Repository navigation
ui(network-status): remove Reticulum Information card - #1187
Merged
Merged
Conversation
Drop the Reticulum Info Card (RNS availability, storage path, transport, lock state, and the Process Persistence/heartbeat section) from the Settings > Network Status screen, along with its per-second refresh polling. The card's dedicated unit tests are removed with it. No other card depends on that poll: debug info elsewhere is delivered event-driven via debugInfoFlow.
Contributor
 |
This comment has been minimized.
This comment has been minimized.
Greptile P1: the removed Reticulum Info card owned the only 1Hz refreshDebugInfo() poll on this screen, and the python backend never emits debugInfoFlow (only the kotlin backend does). Without that poll, InterfacesCard online-state froze on pythonBackend. Lift the periodic refresh to the screen level (lifecycle-gated) so the remaining cards keep updating. Net: card UI removed, live refresh kept.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the "Reticulum Information" card from Settings > Network Status, per Torlando.
ReticulumInfoCardcomposable (RNS availability, storage path, transport enabled, multicast/wake lock state, and the Process Persistence/heartbeat section) and its call site inIdentityScreen.kt.LaunchedEffect,rememberLifecycleTickerMillis).IdentityScreenPersistenceTest.kt(all 17 tests exercised only this card).Side effect
The card ran a 1Hz
LaunchedEffectthat polledrefreshDebugInfo(). That per-second wake is gone with the card. No other card depends on that poll: debug info is otherwise delivered event-driven viadebugInfoFlow.Verification
./gradlew :app:compileNoSentryKotlinBackendDebugKotlinandcompileNoSentryKotlinBackendDebugUnitTestKotlinpass (exit 0) on this branch.noSentryKotlinBackenddebug and installed to the device (Samsung, arm64); Network Status screen renders without the card, data preserved (in-place upgrade, versionCode climbed).