fix: normalize peer address before duplicate-identity comparison

[torlando-tech]

Summary

On two fixed-MAC peers both running central + peripheral mode, the same physical peer is represented by two address strings: the peripheral (GATT) path stores dev:AA:BB:.. (BlueZ D-Bus device-path form) while the central (scan) path carries the bare AA:BB:... The _check_duplicate_identity comparison saw dev:AA:BB != AA:BB, concluded a false Android MAC rotation, rejected the connection, and detached the peer interface after the grace period.

The data path then dropped: discovery announces routed to 0 peers and the peer never appeared in the destination table.

Fix

Add _normalize_address() that strips the dev: prefix and case-folds. Apply it to both comparison sites in _check_duplicate_identity and the v2.2 scan loop. Genuinely different MACs (true Android MAC rotation) still differ and are still handled.

TDD

test_ble_dup_identity_mac_normalize.py reproduces the false positive (RED before, GREEN after) and guards that true MAC rotation is still rejected. Bind the new _normalize_address helper in the zombie/blacklist test harnesses that call the real method.

Test results

330 passed, 6 failed (all pre-existing: No module named 'dbus', fail identically on clean main).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Fixes MAC address comparison in peer duplicate detection.

The PR appears safe to merge; no new blocking issue was found.

What we checked:

• Scan tests miss the branch: The tests give the scanned peer a known identity and an existing interface, then check whether the peer is selected.
• New tests miss coverage: The workflow runs the tests/ directory and does not ignore the new file. It ignores test_v2_2_mac_sorting.py instead.

Summary

BLE identity checks now normalize addresses before comparing them, so dev: and bare forms of one MAC match across central and peripheral paths. Genuinely different MACs still follow the existing rotation rules.

• Removes the dev: prefix, trims spaces, and folds letter case.
• Adds coverage for matching address forms and genuine MAC changes.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Scan finds a known identity] --> B{Normalized addresses match?}
  B -->|Yes| C[Skip existing interface]
  B -->|No| D{Old connection alive?}
  D -->|Yes| E[Skip new address]
  D -->|No| F[Clean up old address and select new peer]

Loading

_{Reviews (4) · Last reviewed commit: "test: cover scan-loop address-normalizat..."}

[torlando-tech]

@greptile review

[torlando-tech]

@greptile review

[torlando-tech]

@greptile review