Skip to content
This repository was archived by the owner on Jun 30, 2026. It is now read-only.

fix: change number schema types to integer - #93

Merged
v-lebedev merged 1 commit into
masterfrom
fix-integer-schema
Nov 11, 2025
Merged

fix: change number schema types to integer#93
v-lebedev merged 1 commit into
masterfrom
fix-integer-schema

Conversation

@VladasZ

@VladasZ VladasZ commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

"number" type is too generic and in some code generators such as crate typify it will generate float types instead of integers.

Before:

pub enum Operand {
    #[serde(rename = "uint")]
    Uint {
        display_hints: DisplayHints,
        max_value: f64,
        min_value: f64,
        name: VarName,
        size: f64,
    },
    #[serde(rename = "int")]
    Int {
        display_hints: DisplayHints,
        max_value: f64,
        min_value: f64,
        name: VarName,
        size: f64,
    },

After:

pub enum Operand {
    #[serde(rename = "uint")]
    Uint {
        display_hints: DisplayHints,
        max_value: i64,
        min_value: i64,
        name: VarName,
        size: i64,
    },
    #[serde(rename = "int")]
    Int {
        display_hints: DisplayHints,
        max_value: i64,
        min_value: i64,
        name: VarName,
        size: i64,
    },

@VladasZ
VladasZ requested a review from v-lebedev November 11, 2025 13:32
@VladasZ VladasZ changed the title fix: change schema types to integer fix: change number schema types to integer Nov 11, 2025
@v-lebedev
v-lebedev merged commit 7bfda92 into master Nov 11, 2025
2 checks passed
@v-lebedev
v-lebedev deleted the fix-integer-schema branch November 11, 2025 16:03
tochilinak pushed a commit to explyt/tvm-spec that referenced this pull request Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants