Skip to content

Review: what changed folds into the version row - #534

Merged
egeozin merged 4 commits into
mainfrom
fix/review-what-changed-short
Nov 3, 2026
Merged

egeozin merged 4 commits into
mainfrom
fix/review-what-changed-short

Conversation

@egeozin

@egeozin egeozin commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

What and why

A revised draft's review shows what Tin changed above the article. The note was a paragraph between the version row and the copy, up to 2,000 characters of it, so the founder read notes before the page they came to review.

The note now folds into the version row, as picked on the Paper board "Review · what changed, folded" (WC-A):

  • Closed: "What changed" with a down chevron joins Version, Previous version and Compare. Nothing else shows above the article.
  • Open: the item turns to the ink, the chevron points up, and the whole note eases in under the row. Height and opacity move together over about a quarter of a second, with no motion under reduced motion.
  • It stays open across redraws of the same review, and works the same in Decisions and the reader, which share the component.
  • The review returns the whole note, as before.
  • The revision prompt now asks What changed to start with one sentence of at most 25 words that a reader takes in at a glance, with any detail after it in the same section.

An earlier version of this PR cut the note to its first sentence on the server. That's gone: folding keeps the whole note one click away.

Verification

  • node --test web/workflow-review.browser.test.js: 7 passed. The article feedback test now checks that What changed starts closed with a zero-height fold, opens on click with aria-expanded="true", and shows the note.
  • uv run pytest tests/test_workflow_reviews.py against a local Postgres, plus ruff check.
  • Rendered the Aupilot demo's revised article in the packaged dashboard, closed and open: it matches the WC-A board.

Tested on staging

See the comment below for the staging run. Staging has no revised draft yet, so the fold itself was checked with the browser test and the render above.

🤖 Generated with Claude Code

The review page shows the revision's "What changed" note above the article.
The prompt only asked for a short section, so revisions wrote a paragraph and
the page showed up to 2,000 characters of it before the copy. The prompt now
asks for one sentence of at most 25 words, and the review shows the section's
first sentence (or first bullet), cut at a word near 200 characters. Revisions
saved earlier shorten the same way; the whole account stays in Generation notes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@egeozin
egeozin requested a review from a team as a code owner November 3, 2026 00:19
egeozin and others added 3 commits November 2, 2026 19:50
The note now sits behind a What changed item beside Version, Previous version
and Compare. Closed, nothing shows above the article but that row; open, the
item turns to the ink, its chevron points up, and the whole note eases in
under the row. It stays open across redraws of the same review. The review
returns the whole note again, and the revision prompt asks What changed to
start with one sentence a reader takes in at a glance, then any detail.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@egeozin egeozin changed the title Review: what changed is one sentence above the article Review: what changed folds into the version row Nov 3, 2026
@egeozin

egeozin commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Tested on staging (run 41733225552, with main, #524 at 9226457 and #537): app.staging.tin.computer serves the fold (.review-change-fold in workflow-review.css, review-change-toggle in workflow-review.js). Staging has no revised draft to open, so the fold's behaviour is covered by the browser test and the Aupilot render in the description.

@egeozin
egeozin merged commit 24b0fe8 into main Nov 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant