Make firmware probe only react on specific error - #158
Open
mchack-work wants to merge 1 commit into
Open
Conversation
Instead of thinking a TKey is running a device app on any error from the firmware probe, just report a device app if we get the specific ErrResponseStatusNotOK error.
mchack-work
force-pushed
the
fix-firmware-probe
branch
from
September 1, 2026 20:40
c74e782 to
caa90b5
Compare
dehanj
reviewed
Sep 3, 2026
| func (s *Signer) isFirmwareMode() bool { | ||
| nameVer, err := s.tk.GetNameVersion() | ||
| if err != nil { | ||
| if errors.Is(err, tkeyclient.ErrResponseStatusNotOK) { |
Member
There was a problem hiding this comment.
From GetNameVersion, if any other error than ErrResponseStatusNotOK occurs, it will do
return nil, errWhich is not handled, so
return nameVer.Name0 == wantFWName0 &&
nameVer.Name1 == wantFWName1will compare against nil. Isn't that a problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of thinking a TKey is running a device app on any error from the firmware probe, just report a device app if we get the specific ErrResponseStatusNotOK error.
Fixes #157
Type of change
Please tick any that are relevant to this PR and remove any that aren't.
Submission checklist
I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.I have updated the documentation where relevant (readme, dev.tillitis.se etc.)QEMU is updated to reflect changes