Repository navigation
Conversation
Co-authored-by: David Núñez <david@nucypher.com> Co-authored-by: Michalina <michalina.cienciala@akena.co>
…m governance contracts Co-authored-by: Michalina <michalina.cienciala@akena.co>
Co-authored-by: Michalina <michalina.cienciala@akena.co>
| ]; | ||
| int96 authorizedOverall = authorizedOverallValues[i]; | ||
| if (authorizedOverall >= 0) { | ||
| applicationStruct.authorizedOverall += uint96( |
There was a problem hiding this comment.
Why not directly setting applicationStruct.authorizedOverall, rather than using int96 increments/decrements?
There was a problem hiding this comment.
because with just setting value we always can face frontrun tx that will change authorization and now we have to execute one more tx. With addition or subtraction - maximum we need two txs even if one/many will be executed right before upgrade
|
Closing this proposal as obsolete following the TIP-100 changes in #171. Aggregate per-application authorization tracking was intended to support the earlier on-chain staking rewards model; TIP-100 moved beta operator compensation to direct DAO payments and retired the relevant staking flows. The related StableYield proposal in #167 is being retired as well. |
Based on #159
At some moment in the future we want to have contract that will calculate reward per app on chain. For this purpose such contract will need to know overall amount authorized for each application. This PR adds tracking of those values and also one-time function to initialize variables. It's not feasible to calculate current authorized value in contract because we don't have list of all staking providers on chain.
updateAuthorizedOverallallows to add or subtract values from currentauthorizedOverall, it needed in case before upgrading will be any change in authorization amount. Suggested upgrading sequence: calculate authorized amounts right before upgrading, upgrade +updateAuthorizedOverall, in case there is any tx that changes authorization between two previous steps - executeupdateAuthorizedOverallagain.