Repository navigation
build(solidity): upgrade Prettier 3 and reformat sources - #4303
Merged
piotr-roslaniec merged 4 commits intoSep 13, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 8, 2026
…4304) Both Solidity packages now use Solhint 6.2.4. The Git-pinned `solhint-config-keep` dependency is replaced with explicit local rules, preserving its error/warning policy and the existing constructor/assembly overrides. The removed event-naming rule is migrated to `event-name-capwords`. Closes #4214 together with the prerequisite ESLint PR #4302 and Prettier PR #4303. This is stacked on #4303. The stack depends on #4208; coordinate the Node 24 runtime rollout in #4205 and stacked-branch CI support in #4217 before merging the toolchain stack. Warnings remain deliberately non-blocking in this migration. Solhint 6 reports 14 beacon and 12 ECDSA warnings, primarily declaration ordering and state counts, with no errors. The new analyzer detects a few additional ordering cases; the existing error rules are not weakened to accommodate the upgrade. ESLint's existing warning policy is likewise retained in #4302. Validation: both packages pass Solidity lint and formatting/config checks. Targeted probes confirm missing state visibility still fails, valid source passes, and event naming remains a warning. No contract or TypeScript source changes are included. The preceding stack passed strict typechecks, prepack, fresh TypeChain generation, full lint, comparison of all 159 contract ABIs/runtimes and emitted JavaScript, and both functional suites (955 beacon and 673 ECDSA, 44 existing pending).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both Solidity packages now use Prettier 3 and prettier-plugin-solidity 2, with explicit plugin loading and
trailingComma: "all". ECDSA's shell-formatting plugin is updated to the compatible line. The first commit contains only dependency/configuration changes; the second contains only formatter output.Part of #4214; stacked on #4302 (ESLint 10). Solhint 6 follows in the final toolchain PR. This stack builds on #4208; stacked-branch CI is addressed by #4217, and Node 24 rollout by #4205.
Validation on Node 24.11.1: