feat(sentinel): show field-level diff for modified certificates - #302
Merged
Conversation
The certificate diff only reported that a certificate was modified, without showing which sub-fields changed. When an operator changed acme_options or dns_options, the config changes modal showed "Modified: DOMAINS" with the domain list, but no indication of what actually changed. Add a changes map to the modified certificate diff entry, listing each changed field (domains, acme_options, dns_options, importer_options, etc.) with its old and new values. Update the config changes modal to render each changed field with old -> new, following the same pattern used for monitoring changes. Risk assessment: - Impact: operators can now see exactly which certificate sub-fields changed in the config changes modal, instead of just "Modified" - Blast radius: sentinel config watcher diff_certificates and the web config_changes_modal certificate rendering; no apply logic changes - Regression risk: low - the changes map is additive; existing consumers that only read status and config are unaffected - Rollback: plain commit revert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acme_optionsordns_options, the config changes modal showed "Modified: DOMAINS" with the domain list, but no indication of what actually changed.changesmap to the modified certificate diff entry, listing each changed field (domains,acme_options,dns_options,importer_options, etc.) with its old and new values.Test plan
mix test apps/sentinel/test/config/watcher_test.exs --warnings-as-errors(52 tests)mix test apps/deployex_web/test/deployex_web/live/applications/ --warnings-as-errors(76 tests)mix format --check-formattedmix credo --strict apps/sentinel/lib/sentinel/config/watcher.ex apps/deployex_web/lib/deployex_web/live/components/config_changes_modal.exRisk assessment
diff_certificatesand the webconfig_changes_modalcertificate rendering; no apply logic changes.changesmap is additive; existing consumers that only readstatusandconfigare unaffected.Generated with Devin powered by GLM-5.2 High