-
Notifications
You must be signed in to change notification settings - Fork 3
✨ Add WebSocket server to @effectionx/websocket #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taras
wants to merge
16
commits into
main
Choose a base branch
from
feat/websocket-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4bb6293
✨ Add WebSocket server to @effectionx/websocket
taras d87695e
🐛 Fix strict typecheck in server test message assertion
taras 2aabdf0
♻️ Use on/once from @effectionx/node for server events
taras 3a17c86
🏷️ Add explicit types to WebSocketResource.send
taras a098d4a
♻️ Drop redundant per-connection task in websocket server
taras 8f86ee1
✅ Cover close code/reason propagation and accept-queue buffering
taras c418a21
✨ Bound websocket teardown with a close timeout (timebox)
taras 5edf1e8
✨ Add composable close(code, reason) + going-away server shutdown
taras 84c896f
✨ Isolate per-connection errors with scoped + errors stream
taras 1b2da1c
✨ Make WebSocket close timeout configurable
taras 743252b
♻️ Move server teardown into ensure()
taras 7d4add5
♻️ Address server review feedback
taras 9590f22
♻️ Import event helpers from @effectionx/node/events
taras 67dcf31
🐛 Read the socket error through ThrownValueError's cause
taras 24f1957
🐛 Await the server close callback on teardown
taras d51c18e
✅ Cover multi-connection and silent-peer server teardown
taras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export * from "./websocket.ts"; | ||
| export * from "./server.ts"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.