Skip to content

Improve Assets handler: Performance and ensuring that late registration doesnt stop enqueueing - #2067

Open
bordoni wants to merge 11 commits into
masterfrom
fix/ensure-assets-register-to-wp
Open

Improve Assets handler: Performance and ensuring that late registration doesnt stop enqueueing#2067
bordoni wants to merge 11 commits into
masterfrom
fix/ensure-assets-register-to-wp

Conversation

@bordoni

@bordoni bordoni commented Apr 5, 2024

Copy link
Copy Markdown
Member

This will need to be ported to https://github.com/stellarwp/assets/ later.

Changes here are:

  1. enforcing a better performance by avoiding logic for already enqueued asset.
  2. Ensure that late registration doesn't prevent enqueuing/registering with WP.

Change number 2 is vital for ensuring that Assets that are registered JIT still get enqueued, example Elementor Widgets.

@bordoni bordoni added the code review Status: requires a code review. label Apr 5, 2024
@bordoni bordoni self-assigned this Apr 5, 2024
@bordoni bordoni added the hold Status: on hold–do not proceed with other status items. label Apr 5, 2024
@bordoni
bordoni changed the base branch from bucket/event-single-elementor-template-integration to master May 3, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code review Status: requires a code review. hold Status: on hold–do not proceed with other status items.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants