Fix bad pathing creating double-slashes. - #1843
Open
Camwyn wants to merge 4 commits into
Open
Conversation
run `array_filter()` (without a second param - so it jsut removes empty items) on $path before we run `implode()` Part of [ECP-1400] When we implode the $path arrays, ensure we first remove all empty items or we wind up with things like `/site/tec/dev/themes/twentytwenty//tribe/events-pro//custom-tables-v1` instead of `/site/tec/dev/themes/twentytwenty/tribe/events-pro/custom-tables-v1` :movie_camera: https://d.pr/v/ihcOLc
lucatume
suggested changes
Dec 1, 2022
lucatume
left a comment
lucatume
left a comment
Contributor
There was a problem hiding this comment.
Add some test coverage.
bordoni
approved these changes
May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do so we run
array_filter()(without a second param - so it just removes empty items) on $path before we runimplode().When we implode the $path arrays, ensure we first remove all empty items or we wind up with things like
/site/tec/dev/themes/twentytwenty//tribe/events-pro//custom-tables-v1instead of/site/tec/dev/themes/twentytwenty/tribe/events-pro/custom-tables-v1🎥 https://d.pr/v/ihcOLc
Part of ECP-1400
Related: https://github.com/the-events-calendar/events-pro/pull/2139